More parameters to make bacula::cient working on Solaris #7

Merged
merged 2 commits into from Dec 18, 2014

Projects

None yet

4 participants

@pesimon

Please have a look, to the following changes

  • make config template a paramenter
  • default to linux package names and paths

    Example usage on solaris with CSWbaclua package

    class { 'bacula::client':
    director_server => 'director',
    director_password => 'xxxxxxx',
    client_package => 'CSWbaculaclient',
    package_provider => "pkgutil",
    client_conf => "/opt/csw/etc/bacula/bacula-fd.conf",
    client_service => "cswbacula",
    working_dir => "/opt/csw/var/bacula/working",
    pid_dir => "/opt/csw/var/bacula/run"
    }

Peter Simon Add Solaris support for bacula client
   - make config template a paramenter
   - default to linux package names and paths

    Example usage on solaris with CSWbaclua package

      class { 'bacula::client':
         director_server   => 'director',
         director_password => 'xxxxxxx',
         client_package    => 'CSWbaculaclient',
         package_provider  => "pkgutil",
         client_conf       => "/opt/csw/etc/bacula/bacula-fd.conf",
         client_service    => "cswbacula",
         working_dir       => "/opt/csw/var/bacula/working",
         pid_dir           => "/opt/csw/var/bacula/run"
      }
36e5c32
@ccaum

This is pretty awesome. Thanks. Can you update the parameters list in the README and maybe add a section about how to manage it in Solaris?

@pesimon

Sure. Do you think it'd make sense to introduce top scope equivalents to all new bacula::client parameters?

@ccaum

@pesimon Sorry I've been lagging on this. It's been fairly busy around here. Yes, I think all parameters should have top scope equivalents. My goal is to keep this module configurable from the top scop/ENC level as well as class parameters. I'm also trying to stick to having a single point of entry, being the bacula class. This makes delegation to sub-classes easier and makes things like validation easier.

@ccaum

@justinellison Can you take a look at this and merge if it works?

@justinellison

We've phased out all of our Solaris hosts, so I can't test for the positive. However, so long as it doesn't break the Linux path, I'll take @pesimon word for it that it does work on Solaris. Give us a week or two to get the bandwidth to get our bacula project moving again so we can test it, then I'll merge it.

@underscorgan underscorgan merged commit 3622d01 into voxpupuli:master Dec 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment