Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process plugin silently breaks processmatch/process defines. #652

Closed
bzed opened this issue Feb 22, 2017 · 1 comment
Closed

Process plugin silently breaks processmatch/process defines. #652

bzed opened this issue Feb 22, 2017 · 1 comment
Labels
bug Something isn't working

Comments

@bzed
Copy link
Contributor

bzed commented Feb 22, 2017

@devfaz with 395036a you've silently broken the usage of collectd::plugin::processes::processmatch and collectd::plugin::processes::process as the concat fragments from both defines are not collected anymore unless you've specified a process or processmatch option in the collectd::plugin::processes class.

The correct fix would be to use collectd from wheezy-backports or maybe make collectd monitor itself by default.

oscarkraemer added a commit to oscarkraemer/puppet-collectd that referenced this issue Nov 8, 2017
Revert "collectd may fail to start in wheezy if processes-plugin
is used without any process"

There is an issue open issue on puppet-collectd:
voxpupuli#652

This reverts commit 395036a.
oscarkraemer added a commit to oscarkraemer/puppet-collectd that referenced this issue Nov 8, 2017
This fixes a old silent bug that was created by
395036a

This commit makes it possible define single process again like:
collectd::plugin::processes::process { 'collectd' : }
Without also having to create:
class { 'collectd::plugin::processes':
  processes => [ 'foo', 'bar' }

This fixes the issues voxpupuli#652 and voxpupuli#595.
@juniorsysadmin juniorsysadmin added the bug Something isn't working label Nov 8, 2017
@juniorsysadmin
Copy link
Member

Fixed by #712

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants