Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin::mysql::database - remove default 'UNSET' values #724

Closed
juniorsysadmin opened this issue Nov 12, 2017 · 2 comments · Fixed by #970
Closed

plugin::mysql::database - remove default 'UNSET' values #724

juniorsysadmin opened this issue Nov 12, 2017 · 2 comments · Fixed by #970
Labels
enhancement New feature or request

Comments

@juniorsysadmin
Copy link
Member

Use better types to make it clearer that these parameter are required

@juniorsysadmin juniorsysadmin added the enhancement New feature or request label Nov 12, 2017
@ph448
Copy link
Contributor

ph448 commented May 8, 2021

@juniorsysadmin what would you consider a 'better type' for the username? IMO the best course of action is to not provide a default and make the manifest fail early and hard with the familiar message saying a String was expected.
scratching a personal itch I have a PR cooking that makes supplying the password optional and sets the default hostname to 'localhost', as this better matches the expectations a MySQL user might have, and it would be nice to complete a fix for this issue.

@juniorsysadmin
Copy link
Member Author

IMO the best course of action is to not provide a default and make the manifest fail early and hard with the familiar message saying a String was expected.

@ph448 Sounds reasonable. I have not touched Puppet for years though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants