Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collectd fails to load when using multiple hostname format values #953

Closed
leifmadsen opened this issue Sep 4, 2020 · 0 comments · Fixed by #954
Closed

collectd fails to load when using multiple hostname format values #953

leifmadsen opened this issue Sep 4, 2020 · 0 comments · Fixed by #954

Comments

@leifmadsen
Copy link
Contributor

collectd will fail to load the virt plugin when the HostnameFormat contains multiple parameters. Use of double quotes is invalid.

How to reproduce (e.g Puppet code you use)

Pass hostname_format to the virt plugin configuration with multiple valid values, e.g. metadata uuid name

leifmadsen added a commit to leifmadsen/puppet-collectd that referenced this issue Sep 4, 2020
Use of double-quotes around the HostnameFormat field in the virt plugin erb
template is wrong when using multiple names. Error generated will be
[2020-09-04 03:17:04] virt plugin: unknown HostnameFormat field: name metadata uuid
when setting the configuration to

HostnameFormat "name metadata uuid"

Simply removing the double quotes allows for a successful virt plugin load. Source
in collectd justifying this change is at: https://github.com/collectd/collectd/blob/main/src/virt.c#L834

Closes voxpupuli#953
leifmadsen added a commit to leifmadsen/puppet-collectd that referenced this issue Sep 4, 2020
Use of double-quotes around the HostnameFormat field in the virt plugin erb
template is wrong when using multiple names. Error generated will be
[2020-09-04 03:17:04] virt plugin: unknown HostnameFormat field: name metadata uuid
when setting the configuration to

HostnameFormat "name metadata uuid"

Simply removing the double quotes allows for a successful virt plugin load. Source
in collectd justifying this change is at: https://github.com/collectd/collectd/blob/main/src/virt.c#L834

Fixes voxpupuli#953
leifmadsen added a commit to leifmadsen/puppet-collectd that referenced this issue Sep 18, 2020
Use of double-quotes around the HostnameFormat field in the virt plugin erb
template is wrong when using multiple names. Error generated will be
[2020-09-04 03:17:04] virt plugin: unknown HostnameFormat field: name metadata uuid
when setting the configuration to

HostnameFormat "name metadata uuid"

Simply removing the double quotes allows for a successful virt plugin load. Source
in collectd justifying this change is at: https://github.com/collectd/collectd/blob/main/src/virt.c#L834

Fixes voxpupuli#953
leifmadsen added a commit to leifmadsen/puppet-collectd that referenced this issue Nov 25, 2020
Use of double-quotes around the HostnameFormat field in the virt plugin erb
template is wrong when using multiple names. Error generated will be
[2020-09-04 03:17:04] virt plugin: unknown HostnameFormat field: name metadata uuid
when setting the configuration to

HostnameFormat "name metadata uuid"

Simply removing the double quotes allows for a successful virt plugin load. Source
in collectd justifying this change is at: https://github.com/collectd/collectd/blob/main/src/virt.c#L834

Fixes voxpupuli#953
leifmadsen added a commit to leifmadsen/puppet-collectd that referenced this issue Dec 1, 2020
Use of double-quotes around the HostnameFormat field in the virt plugin erb
template is wrong when using multiple names. Error generated will be
[2020-09-04 03:17:04] virt plugin: unknown HostnameFormat field: name metadata uuid
when setting the configuration to

HostnameFormat "name metadata uuid"

Simply removing the double quotes allows for a successful virt plugin load. Source
in collectd justifying this change is at: https://github.com/collectd/collectd/blob/main/src/virt.c#L834

Fixes voxpupuli#953
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant