Rely on autorequires of files when using concat #1003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously all the concat's created typically in /etc/collect.d were subject to File['collectd.d'] -> Concat <| tag == 'collectd' |> to ensure the directory was in place first. This turns out to be too greedy and can cause problems as per voxpupuli#1000. This declaration is unnecessary as concat creates a file type and this auto-requires the directory one level above.
traylenator
force-pushed
the
newrequire
branch
from
f0cc2e4
to
3ed6558
Compare
|
Test failures are unrelated to this MR. |
bastelfreak
approved these changes
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Previously all the concat's created typically in /etc/collect.d were subject to
File['collectd.d'] -> Concat <| tag == 'collectd' |>
to ensure the directory was in place first.
This turns out to be too greedy and can cause problems as per #1000.
This declaration is unnecessary as concat creates a file type
and this auto-requires the directory one level above.
This Pull Request (PR) fixes the following issues
Fixes #1000