add new parameter module_import in plugin::python::module #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
contargo-development
force-pushed
the
python_module_name_vs_import
branch
from
73ec4ad
to
4b8fdaf
Compare
|
Hi @contargo-development, thanks for the PR. We're currently planning another PR which fixes the rubocop issues. Please rebase after that one got merged. |
* set it to $module per default * used in template for the case the name= is different from Import
contargo-development
force-pushed
the
python_module_name_vs_import
branch
from
4b8fdaf
to
c42d22d
Compare
|
Hi @bastelfreak, |
|
Ah stupid me, sorry for not linking it. However it got already merged, thanks for rebasing. |
|
@bastelfreak no problem, thanks for merging :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if a python-plugin sets its own name which is different from the Import Name like collectd-haproxy (https://pypi.python.org/pypi/collectd-haproxy) does:
'Import "collectd_haproxy" ' and 'Module haproxy'
There has to be a way to be able to adjust one of these…