Plugin turbostat #642
Merged
Plugin turbostat #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Jan 30, 2017
manifests/plugin/turbostat.pp
Outdated
|
|
||
| include ::collectd | ||
|
|
||
| validate_string($core_c_states, $package_c_states, $tcc_activation_temp, $running_average_power_limit) |
There was a problem hiding this comment.
can you instead declare the variables as String datatype?
bastelfreak
reviewed
Jan 30, 2017
manifests/plugin/turbostat.pp
Outdated
|
|
||
| validate_string($core_c_states, $package_c_states, $tcc_activation_temp, $running_average_power_limit) | ||
| if $system_management_interrupt { | ||
| validate_bool($system_management_interrupt) |
There was a problem hiding this comment.
same here, define as bool please
|
@bastelfreak Did you mean the puppet 4 type definitions instead validate functions? |
|
yep |
|
@bastelfreak What about erb? Should I use epp instead erb? |
|
@jkroepke can you take a look at this PR as well? |
jkroepke
force-pushed
the
plugin_turbostat
branch
from
ee12486
to
9a2fbce
Compare
|
@bastelfreak sure. I will try it. |
jkroepke
force-pushed
the
plugin_turbostat
branch
from
c80492a
to
2e8e315
Compare
jkroepke
force-pushed
the
plugin_turbostat
branch
from
fd6bf89
to
db955ee
Compare
bastelfreak
added
enhancement
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added plugin turbostat See: https://collectd.org/documentation/manpages/collectd.conf.5.shtml#plugin_turbostat