Oracle Database definition must be at bottom #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinzent
requested changes
Feb 10, 2017
There was a problem hiding this comment.
The spec test needs an update too. https://travis-ci.org/voxpupuli/puppet-collectd/jobs/197596946#L4676
| @@ -17,7 +17,7 @@ | |||
| validate_array($query) | |||
|
|
|||
| concat::fragment { "collectd_plugin_oracle_database_${name}": | |||
| order => '10', | |||
| order => '20', | |||
There was a problem hiding this comment.
What error message did you get when it was not ordered at the bottom?
There was a problem hiding this comment.
Collectd sends errors to syslog on every collect. I havn't the full messages here.
vinzent
added
needs-work
jkroepke
force-pushed
the
collectd_oracle_fix
branch
from
da70b68
to
766b869
Compare
|
@vinzent Spec Tests updated. |
|
@vinzent @bastelfreak It's possible to add this PR to the #641 ? Without this PR, the oracle module is non functional. |
bastelfreak
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
today, we test the module against a real oracle database and we figure out, the database configuration must be at the bottom.