Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added cuda GPU plugin #645

Merged
merged 3 commits into from Feb 12, 2017
Merged

Added cuda GPU plugin #645

merged 3 commits into from Feb 12, 2017

Conversation

jskarpe
Copy link
Contributor

@jskarpe jskarpe commented Feb 9, 2017

No description provided.

@jskarpe
Copy link
Contributor Author

jskarpe commented Feb 10, 2017

The acceptance test for Debian timed out. What's the preferred way to trigger restart of that job?

vinzent
vinzent approved these changes Feb 10, 2017
View reviewed changes
Copy link

@vinzent vinzent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm not a user of this module, but looking at the code it looks fine. does not introduce a breaking change and provides spec tests for the class.

manifests/plugin/cuda.pp Outdated
@@ -0,0 +1,78 @@
# cuda plugin
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would start directly with puppet-strings docs : https://github.com/puppetlabs/puppet-strings#documenting-puppet-classes-and-defined-types

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for puppet-strings

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got an example?

@vinzent vinzent added the enhancement New feature or request label Feb 10, 2017
@jskarpe
Copy link
Contributor Author

jskarpe commented Feb 10, 2017

This what you're looking for?

@bastelfreak
Copy link
Member

Thanks @yuav!

@bastelfreak bastelfreak merged commit 9087af7 into voxpupuli:master Feb 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastelfreak bastelfreak bastelfreak left review comments

@vinzent vinzent vinzent approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jskarpe @bastelfreak @vinzent