Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add $measureresponsecode for curl plugin #659

Merged
merged 2 commits into from Apr 1, 2017

Conversation

azhurbilo
Copy link
Contributor

according this documentation page https://collectd.org/documentation/manpages/collectd.conf.5.shtml#plugin_curl

we can start collecting response code

@azhurbilo
Copy link
Contributor Author

Yep, I also saw this failed check before starting add any changes, so it's not related to my MR )

Warning: Dependency puppetlabs/stdlib has an open ended dependency version requirement >= 4.6.0
Warning: Dependency puppetlabs/concat has an open ended dependency version requirement >= 1.2.5
Warning: Dependency stahnma-epel has an open ended dependency version requirement >= 1.2.2
Warning: Dependency puppetlabs-apt has an open ended dependency version requirement >= 2.2.0
manifests/init.pp:52:arrow_on_right_operand_line:WARNING:arrow should be on the right operand's line
manifests/init.pp:55:arrow_on_right_operand_line:WARNING:arrow should be on the right operand's line
manifests/init.pp:56:arrow_on_right_operand_line:WARNING:arrow should be on the right operand's line
manifests/init.pp:57:arrow_on_right_operand_line:WARNING:arrow should be on the right operand's line

@bastelfreak
Copy link
Member

The 4 warnings about dependencies can be ignoried. We always test against master branch, not releases, to catch errors before they are released.

The other warnings are caused by a lately updated puppet-lint plugin. Are you able to fix them? Otherwise we can do it in a separate pull request.

@oranenj oranenj merged commit 91844a7 into voxpupuli:master Apr 1, 2017
@oranenj
Copy link
Contributor

oranenj commented Apr 1, 2017

Looks good to me. Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants