Install 'collectd-python' package on Amazon Linux. #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like tests are failing because of (very) recent changes to the puppetlabs-apt module -- it's now referencing |
bastelfreak
reviewed
May 26, 2017
manifests/plugin/python.pp
Outdated
| @@ -38,7 +38,7 @@ | |||
| $ensure_real = 'absent' | |||
| } | |||
|
|
|||
| if $::operatingsystem == 'Fedora' { | |||
| if $::operatingsystem == 'Fedora' or $::operatingsystem == 'Amazon' { | |||
There was a problem hiding this comment.
can you use the new facts syntax here? $facts['os']['name'] is probably correct.
bastelfreak
reviewed
May 26, 2017
spec/default_module_facts.yml
Outdated
| @@ -4,3 +4,7 @@ python_dir: '/usr/local/lib/python2.7/dist-packages' | |||
| operatingsystem: 'Debian' | |||
| lsbdistid: 'Debian' | |||
| lsbdistcodename: 'wheezy' | |||
| os: | |||
There was a problem hiding this comment.
This is, in my opinion, a bad idea. We should instead migrate the failing tests to rspec-puppet-facts. I will have a look at it and provide a PR
|
Hi @irgeek , thanks for the PR. Can you please rebase it against latest master? |
|
@irgeek ping |
|
@bastelfreak I've rebased this and updated to use |
juniorsysadmin
approved these changes
Oct 23, 2017
|
@irgeek we fixed this in master. Thanks for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the package installation check in
manifests/plugin/python.ppchanged from all RedHat distress to Fedora the module stopped working on Amazon Linux. This change updates the check to install the module on Amazon Linux.