Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rspec-puppet-facts integration #673

Merged
merged 92 commits into from Jul 19, 2017

Conversation

bastelfreak
Copy link
Member

No description provided.

@bastelfreak
Copy link
Member Author

this got pulled out from #672

@bastelfreak bastelfreak mentioned this pull request May 27, 2017
@bastelfreak bastelfreak changed the title [WIP] rspec-puppet-facts integration part1 [WIP] rspec-puppet-facts integration May 27, 2017
@bastelfreak bastelfreak changed the title [WIP] rspec-puppet-facts integration rspec-puppet-facts integration May 27, 2017
@bastelfreak
Copy link
Member Author

spec tests itself are fine, but they are failling because they take too much time. I'm not sure how we should deal with this. We can probably drop a huge amount of existing tests.

@tpoindessous
Copy link

Hi

the test are failing because of Travis ? If so, can this page help you ?

https://docs.travis-ci.com/user/common-build-problems/#My-builds-are-timing-out

They said that you can prefix your command with travis_wait like this :
install: travis_wait mvn install

If it's not that, sorry to bother you.

Thanks !

@alexjfisher
Copy link
Member

@bastelfreak Instead of dropping tests, you could just test a subset of the OSes instead of all the ones from metadata.json.

@ekohl
Copy link
Member

ekohl commented Jun 27, 2017

@oranenj oranenj merged commit 09978f6 into voxpupuli:master Jul 19, 2017
@bastelfreak bastelfreak deleted the rspec_puppet_facts branch July 19, 2017 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants