Add support for nut plugin (#621) #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like the spec overhaul caused this to break, and need a rebase/fixup again. |
oranenj
requested changes
Jul 19, 2017
|
@trustchk can you please rebase? We fixed the spec issues in our master branch. |
bastelfreak
force-pushed
the
nut
branch
3 times, most recently
from
3965e57
to
24b6138
Compare
bastelfreak
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase of @amishHammer PR #621 against current master but without the change to the types.db handling and with a fix for the linter warning. It also includes a spec test (which might need some additions).