Fix sensors plugin params #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @archii , thanks for the PR. Can you please rebase it against latest master? Also check the used email address in your commits, it isn't asociated with your github account. |
fix collectd::plugin::sensors template for sensors param
archii
force-pushed
the
fix-sensors-plugin-params
branch
from
940f4ac
to
e2e87ba
Compare
|
Cheers @bastelfreak. I rebased and fixed up my e-mail address. Travis-CI tests are passing now. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The class parameter and template variable for the sensors plugin didn't match and did not produce the expected configuration.
This PR should allow for specifying a set of sensors for the collectd sensors plugin to report on. I've added an rspec test for the collectd::plugin::sensors class as well.
Some tests in travis-ci are failing due to warnings for "open ended dependency version requirements", but this was the case before this PR.