Remove interval parameter from write plugins. #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There seem to be some puppet lint issues. Could you fix those? |
|
Hi @kbor, thanks for the PR. Can you please rebase it against latest master? |
It makes no sense to configure interval for write plugins. Collectd has no concept of interval for write plugins and if configured, it is silently ignored. It is therefore better to remove it from the configuration so that manifests don't give a false impression that this parameter does something useful.
|
Hi, yes, sorry, didn't notice. Lint fixed and rebased. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, to my knowledge it makes no sense to configure interval for write plugins. Collectd has no concept of interval for write plugins and if configured, it is silently ignored. It is therefore better to remove it from the configuration so that manifests don't give a false impression that this parameter does something useful.