Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update version for collectd package #752

Merged
merged 1 commit into from
Feb 13, 2018
Merged

update version for collectd package #752

merged 1 commit into from
Feb 13, 2018

Conversation

vaclandic
Copy link
Contributor

No description provided.

@bastelfreak
Copy link
Member

Thanks for the PR @vaclandic! The Pattern is getting quite long. Could you please put it into its own datatype? We already have a few in https://github.com/voxpupuli/puppet-collectd/tree/master/types

@bastelfreak bastelfreak added the needs-work not ready to merge just yet label Feb 12, 2018
@vaclandic
Copy link
Contributor Author

@bastelfreak Complete. Could you check please.

@bastelfreak
Copy link
Member

@vaclandic can you check the used author name/email address in the last commit? The email address isn't associated with your github account.

@vaclandic
Copy link
Contributor Author

@bastelfreak Sorry. Complete

@bastelfreak bastelfreak merged commit b61389a into voxpupuli:master Feb 13, 2018
@bastelfreak bastelfreak added enhancement New feature or request and removed needs-work not ready to merge just yet labels Feb 13, 2018
@bastelfreak
Copy link
Member

Thanks!

@alexjfisher alexjfisher mentioned this pull request Nov 11, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vaclandic @bastelfreak