Use data types, remove anchors #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
juniorsysadmin
commented
Apr 1, 2018
juniorsysadmin
commented
- Only allow Boolean for $purge
- Only allow Boolean for $recurse
- Only allow Integer for $write_queue_limit_low
- Only allow Integer for $write_queue_limit_high
- Don't allow undef for $manage_service
- Replace anchors with contain
- Remove some unecessary tests
- Only allow Boolean for $purge - Only allow Boolean for $recurse - Only allow Integer for $write_queue_limit_low - Only allow Integer for $write_queue_limit_high - Don't allow undef for $manage_service - Replace anchors with contain - Remove some unecessary tests
juniorsysadmin
commented
Apr 1, 2018
| String $package_ensure = $collectd::params::package_ensure, | ||
| Optional[Array] $package_install_options = $collectd::params::package_install_options, | ||
| Stdlib::Fqdn $package_keyserver = $collectd::params::package_keyserver, | ||
| Variant[String[1],Array[String[1]]] $package_name = $collectd::params::package_name, |
There was a problem hiding this comment.
#269 Appears to still affect recent Debian families
bastelfreak
reviewed
Apr 1, 2018
| @@ -9,20 +9,13 @@ | |||
|
|
|||
| options = os_specific_options(facts) | |||
| context 'with all defaults' do | |||
| it { is_expected.to contain_class('collectd') } | |||
There was a problem hiding this comment.
why did you remove those two?
There was a problem hiding this comment.
When inside init.pp we know that a class called collectd will always be there. I just didn't see any value to the test.
Same with params.
bastelfreak
reviewed
Apr 1, 2018
| it { is_expected.to contain_file('collectd.conf').without_content } | ||
| it { is_expected.to contain_file('collectd.d').with_ensure('directory') } | ||
| it { is_expected.to contain_file_line('include_conf_d').with_ensure('absent') } | ||
| it { is_expected.to contain_file_line('include_conf_d_dot_conf').with_ensure('present') } | ||
| it { is_expected.to contain_package(options[:package]).with_ensure('present') } | ||
| it { is_expected.to contain_package(options[:package]).with_install_options(nil) } | ||
| it { is_expected.to contain_class('collectd::install').that_comes_before('Class[collectd::config]') } |
There was a problem hiding this comment.
those checks should still be valid, since we use ->?
There was a problem hiding this comment.
Valid, but again I don't think it is useful, as we don't have any conditional logic which will result in the order of classes changing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.