collectd::plugin::network - Add data types #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
juniorsysadmin
commented
Apr 3, 2018
juniorsysadmin
commented
- $port is now required to be an Integer type, not String
- $port is now required to be an Integer type, not String
bastelfreak
reviewed
Apr 3, 2018
| @@ -0,0 +1,2 @@ | |||
| # | |||
| type Collectd::Network::SecurityLevel = Enum['Encrypt', 'Sign', 'None'] | |||
There was a problem hiding this comment.
should we namespace this or use a shorter name, like: Collectd::SecurityLevel? That would keep the lines in the Puppet files shorter.
There was a problem hiding this comment.
I was trying to keep it consistent...I'm not sure that you can avoid many long lines when using types though.
bastelfreak
approved these changes
Apr 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.