Validate bind view parameters #796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
May 21, 2018
| Boolean $resolverstats = false, | ||
| Boolean $serverstats = true, | ||
| Boolean $zonemaintstats = true, | ||
| Array[Collectd::Bind::View] $views = [], |
|
Hi @smortex, thanks for the patch! Can you add a unit test that verifies that this is now working (provide any valid data to $views) |
|
@bastelfreak done :-) I am neither satisfied by matching lines independently (multiple lines would match when using views) and matching multiple lines in a single test (not easily readable). If you have some advice/opinion regarding this, I would be happy to learn it! |
|
Ooops, rubocop is not configured to enforce trailing comas 😄 I might have missed a mail from Travis-CI… Fixed BTW! |
juniorsysadmin
approved these changes
May 22, 2018
bastelfreak
approved these changes
May 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This tiny Pull-Request add a custom type for validating the values passed to
$collectd::plugin::bind::views. Without this safety belt, you can end up with a useless (but surprisingly valid!) configuration file:This Pull Request (PR) fixes the following issues
n/a