Add amqp1 plugin support #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
May 28, 2018
| } | ||
| end | ||
|
|
||
| it { is_expected.to contain_file('amqp1.load').with(content: %r{<Transport "transport">}) } |
There was a problem hiding this comment.
can you add a it { is_expected.to compile.with_all_deps }
bastelfreak
reviewed
May 28, 2018
templates/plugin/amqp1.conf.erb
Outdated
| @@ -0,0 +1,46 @@ | |||
| <Plugin amqp1> | |||
There was a problem hiding this comment.
can you please provide this as an epp and not erb template? We agreed on epp some time ago and documented it in our review guideline at https://voxpupuli.org/docs/#reviewing-a-module-pr
There was a problem hiding this comment.
Ok, didn't notice this as all templates are in ERB. Will rewrite the template then.
paramite
force-pushed
the
feature/amqp1
branch
8 times, most recently
from
5d2f65b
to
af6d6a7
Compare
|
@paramite can you take a look at the failing travis jobs? |
|
Yes, I'mrreally trying, but EPP and syntax check is giving me hard times :). |
paramite
force-pushed
the
feature/amqp1
branch
2 times, most recently
from
a551bf8
to
733e214
Compare
This patch adds possibility to configure amqp1 plugin added recently to collectd [1]. [1] collectd/collectd#2618
|
@bastelfreak Done. |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This patch adds possibility to configure amqp1 plugin added recently
to collectd [1].
[1] collectd/collectd#2618