drop centos 6 support #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CentOS 6 is too old, the provided packages in epel don't work anymore with the module. Some failures can be seen at voxpupuli#807
|
oh noes. this makes me very sad to see this merged! 😢 I've been building collectd from the instructions here and successfully used the module with 5.x versions on RHEL6 for a year or two now. You could also get them from https://pkg.ci.collectd.org/rpm/collectd-5.8/epel-6-x86_64/. I have a relatively large fleet of RHEL6 boxes managed by this module - would it be OK to submit PRs in case any functionality there gets broken? |
|
@dannygoulder sure! As long as it works, has tests and the OS gets support upstream we are happy to review and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CentOS 6 is too old, the provided packages in epel don't work anymore
with the module. Some failures can be seen at #807
Pull Request (PR) description
This Pull Request (PR) fixes the following issues