processes: Add missing options #822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will add more tests in the next push |
sileht
force-pushed
the
sileht/processes
branch
2 times, most recently
from
6ff259e
to
604af3e
Compare
sileht
force-pushed
the
sileht/processes
branch
2 times, most recently
from
5af89e3
to
b61462c
Compare
|
@bastelfreak can you take a look ? |
bastelfreak
reviewed
Jul 9, 2018
manifests/plugin/processes.pp
Outdated
| @@ -5,6 +5,9 @@ | |||
| $interval = undef, | |||
| Optional[Array] $processes = undef, | |||
| Optional[Array] $process_matches = undef, | |||
| Optional[Boolean] $collect_context_switch = undef, | |||
There was a problem hiding this comment.
can you please align all = chars?
bastelfreak
reviewed
Jul 9, 2018
| @@ -25,21 +28,29 @@ | |||
| } | |||
| concat::fragment { 'collectd_plugin_processes_conf_header': | |||
| order => '00', | |||
| content => '<Plugin processes>', | |||
| content => epp('collectd/plugin/processes-header.conf.epp'), | |||
bastelfreak
reviewed
Jul 9, 2018
| @@ -1,14 +1,22 @@ | |||
| define collectd::plugin::processes::process ( | |||
| $process = $name, | |||
| $ensure = 'present' | |||
| $ensure = 'present', | |||
| Optional[Boolean] $collect_context_switch = undef, | |||
This change add some missing options: * CollectContextSwitch * CollectFileDescriptor * CollectMemoryMaps This options can be set globally or per process/processmatch.
|
Thanks @sileht ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
processes: Add missing options
This change add some missing options:
This options can be set globally or per process/processmatch.