Add powerdns plugin #824
Merged
Add powerdns plugin #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bastelfreak can you take a look ? |
bastelfreak
reviewed
Jul 9, 2018
manifests/plugin/powerdns.pp
Outdated
| # See http://collectd.org/documentation/manpages/collectd.conf.5.shtml#plugin_powerdns | ||
| class collectd::plugin::powerdns ( | ||
| $ensure = 'present', | ||
| $order = 10, |
There was a problem hiding this comment.
please add datatypes for all parameters.
bastelfreak
reviewed
Jul 9, 2018
manifests/plugin/powerdns.pp
Outdated
| Optional[String] $local_socket = undef, | ||
| ) { | ||
|
|
||
| include ::collectd |
There was a problem hiding this comment.
please don't add the :: in front of classes
bastelfreak
reviewed
Jul 9, 2018
| define collectd::plugin::powerdns::recursor ( | ||
| $ensure = 'present', | ||
| Optional[String] $socket = undef, | ||
| Array[String] $collect = [], |
There was a problem hiding this comment.
please align the = chars. For all the strings you could also do something like Optional[String[1]] which enforces a minimal string length of 1, so '' isn't valid
bastelfreak
reviewed
Jul 9, 2018
manifests/plugin/powerdns/server.pp
Outdated
| define collectd::plugin::powerdns::server ( | ||
| $ensure = 'present', | ||
| Optional[String] $socket = undef, | ||
| Array[String] $collect = [], |
bastelfreak
added
enhancement
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add powerdns plugin