Add table plugin #826
Add table plugin #826
Conversation
manifests/plugin/table.pp
Outdated
| class collectd::plugin::table ( | ||
| Enum['present', 'absent'] $ensure = 'present', | ||
| Integer $order = 10, | ||
| Hash[String, Struct[{ |
There was a problem hiding this comment.
Thanks for this awesome and detailed datatype! Can you please abstract it into its own datatype in https://github.com/voxpupuli/puppet-collectd/tree/master/types ?
There was a problem hiding this comment.
Done, awesome I was not aware we can declare type there :)
manifests/plugin/table.pp
Outdated
| }], 1] | ||
| }], 1] $tables, | ||
| ) { | ||
| include ::collectd |
There was a problem hiding this comment.
please don't add the leading :: infront of a class name. This isn't needed anymore since we don't support puppet 3.
| @@ -0,0 +1,27 @@ | |||
| <Plugin "table"> | |||
| <Plugin "table"> | ||
| <% $collectd::plugin::table::tables.each |$path, $table| { -%> | ||
| <Table "<%= $path %>"> | ||
| <% unless $table['plugin'] =~ Undef { -%> |
There was a problem hiding this comment.
if $table['plugin'] is the same as unless $table['plugin'] =~ Undef. I think the if notation is shorter and better to read?
There was a problem hiding this comment.
if plugin is set "", the if version will evaluation to false while the unless to true.
bastelfreak
added
backwards-incompatible
needs-work
|
Thanks for your work @sileht! can you please take a look at the inline comments I made? |
No description provided.