Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add AutoLoadPlugin to global options #840

Merged
merged 1 commit into from
Jul 31, 2018
Merged

add AutoLoadPlugin to global options #840

merged 1 commit into from
Jul 31, 2018

Conversation

mrunge
Copy link
Contributor

@mrunge mrunge commented Jul 31, 2018

Pull Request (PR) description

This PR adds adding AutoLoadPlugin to global options. Usually, it should be disabled.

@paramite
Copy link
Contributor

paramite commented Jul 31, 2018

Please add following, otherwise +1:

diff --git a/spec/classes/collectd_init_spec.rb b/spec/classes/collectd_init_spec.rb
index 2d598e1..aa36921 100644
--- a/spec/classes/collectd_init_spec.rb
+++ b/spec/classes/collectd_init_spec.rb
@@ -41,6 +41,7 @@ describe 'collectd', type: :class do
         let(:params) { { purge_config: true } }
 
         it { is_expected.to contain_file('collectd.conf').with_content(%r{FQDNLookup true}) }
+        it { is_expected.to contain_file('collectd.conf').with_content(%r{AutoLoadPlugin}) }
         it { is_expected.to contain_file('collectd.conf').with_content(%r{Interval}) }
         it { is_expected.to contain_file('collectd.conf').with_content(%r{Timeout}) }
         it { is_expected.to contain_file('collectd.conf').with_content(%r{ReadThreads}) }

@mrunge
Copy link
Contributor Author

mrunge commented Jul 31, 2018

Good suggestion, thank you!

@bastelfreak bastelfreak added the enhancement New feature or request label Jul 31, 2018
@bastelfreak
Copy link
Member

Thanks @mrunge !

@bastelfreak bastelfreak merged commit 27fad3f into voxpupuli:master Jul 31, 2018
@mrunge
Copy link
Contributor Author

mrunge commented Aug 1, 2018

Thank you @bastelfreak for the quick merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants