Adapt write http plugin to new format #848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazeborja
force-pushed
the
fix_544
branch
3 times, most recently
from
fb999a5
to
e8c3459
Compare
|
The failing check seems to be related to the CI flow, not much to the changes... Could someone confirm? |
|
Anyway to retry the tests? |
bastelfreak
reviewed
Aug 29, 2018
bastelfreak
reviewed
Aug 29, 2018
bastelfreak
added
enhancement
bastelfreak
reviewed
Aug 29, 2018
|
All discussions resolved, ready for a second look |
bastelfreak
reviewed
Aug 30, 2018
| Hash $urls = {}, | ||
| Enum['present', 'absent'] $ensure = 'present', | ||
| Hash[String, Hash[String, Scalar]] $nodes = {}, | ||
| Hash[String, Hash[String, Scalar]] $urls = {} |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Allows write http to define either legacy format (urls) or new format (nodes) as defined by the user.
Also adds tests for the write_http plugin that weren't there.
This Pull Request (PR) fixes the following issues