remove reference to collectd::plugin::perl::filename #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @mindriot88 , thanks for the fix! Can you add a unit test so we can ensure that it now works and compiles? |
|
ping @mindriot88 :) |
bastelfreak
force-pushed
the
bug/perl_plugin
branch
from
c8a6126
to
8bb8fb3
Compare
|
The varaible isn't used anywhere else: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
When using the perl plugin the following issue is raised during catalog compilation, upon inspection this appears to be declared from variable which is not used, so removing it seemed the most logic resolution.
This Pull Request (PR) fixes the following issues
error during compilation: Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Unknown variable: 'collectd::plugin::perl::filename'.