Change all port parameters to use Stdlib::Port
#906
Conversation
|
Replaces #870 I created a new PR because I wasn't allowed to push to your branch. |
|
Dear @bastelfreak, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
|
Dear @bastelfreak, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
2 similar comments
|
Dear @bastelfreak, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
|
Dear @bastelfreak, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
Instead of having a mix of strings and integers, all port parameters should be using `Stdlib::Port`. I've also changed some `String`s to `Stdlib::Host`, but none of these should be breaking changes.
bastelfreak
force-pushed
the
stdlib_port
branch
from
3bc644a
to
720186a
Compare
|
Hey people. Would be nice if someone can review and approve this. I would like to wait with the merge until we've some other backwards incompatible changes. |
| @@ -2,9 +2,9 @@ | |||
| # useful if you have multiple instances of different version of pg | |||
| define collectd::plugin::postgresql::database ( | |||
| $ensure = 'present', | |||
There was a problem hiding this comment.
this could use more types ;)
Instead of having a mix of strings and integers, all port parameters
should be using
Stdlib::Port.I've also changed some
Strings toStdlib::Host, but none of theseshould be breaking changes.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues