Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin Mcelog default config #909

Merged
merged 2 commits into from Feb 18, 2020

Conversation

MichalRebisz
Copy link
Contributor

Plugin mcelog default config.

@bastelfreak
Copy link
Member

bastelfreak commented Feb 16, 2020

@MichalRebisz do you know what the default values form collectd are for those settings? Does this break existing configs for people? Also please suqash the commits down to one.

@bastelfreak bastelfreak added needs-feedback Further information is requested needs-work not ready to merge just yet labels Feb 16, 2020
@MichalRebisz
Copy link
Contributor Author

@MichalRebisz do you know what the default values form collectd are for those settings? Does this break existing configs for people? Also please suqash the commits down to one.

Thous are the values I received as default for mcelog from the collectd team. Whether this breaks exsiting configs for people well it shouldn't since mcelog was added about a week ago but I did not have the default values at that point.

Added aditional tests for default values

fixed lint error
@bastelfreak bastelfreak removed needs-feedback Further information is requested needs-work not ready to merge just yet labels Feb 18, 2020
@bastelfreak
Copy link
Member

thanks for the explanation!

@bastelfreak bastelfreak merged commit 20a2f6e into voxpupuli:master Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants