Fix unixsock default path #940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default path for unixsock has been /var/run/collectd-unixsock since the first version of the plugin, 14 years ago: https://github.com/collectd/collectd/blob/4bf284162200a304f0ec8d1f5c2dd93339ddc64c/src/unixsock.c#L48 This path is not overridden by the Debian nor CentOS packages as installed by the module. Use this path by default so that collectdctl without argument can connect to the socket, unbreaking the bolt tasks.
|
thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
The default path for unixsock has been /var/run/collectd-unixsock since
the first version of the plugin, 14 years ago:
https://github.com/collectd/collectd/blob/4bf284162200a304f0ec8d1f5c2dd93339ddc64c/src/unixsock.c#L48
This path is not overridden by the Debian nor CentOS packages as
installed by the module.
Use this path by default so that collectdctl without argument can
connect to the socket, unbreaking the bolt tasks.
This Pull Request (PR) fixes the following issues
n/a