Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ubuntu 20 support #941

Merged
merged 1 commit into from Sep 13, 2021
Merged

Add ubuntu 20 support #941

merged 1 commit into from Sep 13, 2021

Conversation

bastelfreak
Copy link
Member

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

@bastelfreak bastelfreak added the enhancement New feature or request label May 13, 2020
@bastelfreak bastelfreak self-assigned this May 13, 2020
@mmoll mmoll force-pushed the ubuntu20 branch 2 times, most recently from 795fbae to ae5ad69 Compare May 17, 2020 14:43
@mmoll
Copy link
Contributor

mmoll commented May 17, 2020

No idea if the remaining problems are because of collectd/collectd#3370 or something else 🤷‍♂️.

@vox-pupuli-tasks
Copy link

Dear @bastelfreak, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs?
If you need any help, you can reach out to us on our IRC channel voxpupuli on Freenode or our Slack channel voxpupuli at slack.puppet.com.
You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@bastelfreak bastelfreak force-pushed the ubuntu20 branch 2 times, most recently from 75795f1 to 9a32026 Compare June 29, 2021 08:17
ekohl
ekohl reviewed Jul 6, 2021
View reviewed changes
spec/spec_helper_methods.rb Outdated Show resolved Hide resolved
.sync.yml Outdated Show resolved Hide resolved
@bastelfreak bastelfreak force-pushed the ubuntu20 branch 2 times, most recently from 8e45a7e to caa299c Compare July 6, 2021 13:30
ekohl
ekohl reviewed Jul 6, 2021
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we actually have a Boolean $collectd::is_python3_os to remove all the duplicated logic?

manifests/plugin/rabbitmq.pp Outdated Show resolved Hide resolved
@smortex smortex mentioned this pull request Sep 11, 2021
Merged
@smortex
Copy link
Member

smortex commented Sep 11, 2021

I scratched my head with these tests too in #984 (they also now fail with old supported platforms). A lot of these failing tests fail only due to an incompatible execution environment: each one is unique and nothing can be generalized :-/

The rspec-puppet tests in spec/classes / spec/defines already cover these aspects so I proposed to remove the problematic tests in #985. I think that rebasing on top of it would help if you are okay with this.

@bastelfreak
Copy link
Member Author

Should we actually have a Boolean $collectd::is_python3_os to remove all the duplicated logic?

I really like the idea but currently don't have the time to implement this :(

@bastelfreak bastelfreak changed the title Add ubuntu 20 Puppet 6 support Add ubuntu 20 support Sep 13, 2021
@bastelfreak bastelfreak merged commit c516e7a into voxpupuli:master Sep 13, 2021
@bastelfreak bastelfreak deleted the ubuntu20 branch September 13, 2021 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl left review comments

@TuningYourCode TuningYourCode TuningYourCode approved these changes

Assignees

@bastelfreak bastelfreak

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bastelfreak @mmoll @smortex @ekohl @TuningYourCode