Remove redundant white space from python templates #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplifed the template contained:
```
<%# a comment #%>
```
* In puppet 5 this renders as a new line. The prefix of spaces is eaten and a new line is created.
* In puppet 6 this renders as a string of spaces and new line.
The puppet 6 behaviour is better so I expect a bug was fixed sometime.
In reality there should be no spaces in here so change to
```
<%#- a comment -%>
```
which renders as nothing.
|
thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Simplified the epp template contained:
<%# a comment #%>The puppet 6 behaviour is better so I expect a bug was fixed sometime.
In reality there should be no spaces in here so change to
<%#- a comment -%>which renders as nothing and gives us zero catalogue change between 5 and 6 :-)
Extra commit also to remove a redundant blank line from
python-config.conf