Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to set separate interval for database resource #945

Merged
merged 4 commits into from
May 29, 2020

Conversation

oleksandriegorov
Copy link
Contributor

Pull Request (PR) description

By default dpi plugin and each database querying configuration inherits global collectd Interval. While this global interval may be OK for some mail queue checking activities, it is overwhelmingly frequent as for a daily check on a number of email accounts through mysql database. Since collectd dbi plugin support Interval, I would like to have it added into puppet module as well.

P.S. Checked puppet code through puppet validate and ruby template syntax/rendering through
erb db_query_interval=120 -P -x -T '-' templates/plugin/dbi/database.conf.erb
Please consider my pull request.

@ghoneycutt
Copy link
Member

Thanks for the contribution! Could you please add a test. Examples are under https://github.com/voxpupuli/puppet-collectd/tree/master/spec/defines

@vox-pupuli-tasks
Copy link

Dear @oleksandriegorov, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs?
If you need any help, you can reach out to us on our IRC channel voxpupuli on Freenode or our Slack channel voxpupuli at slack.puppet.com.
You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@oleksandriegorov
Copy link
Contributor Author

Dear @oleksandriegorov, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs?
If you need any help, you can reach out to us on our IRC channel voxpupuli on Freenode or our Slack channel voxpupuli at slack.puppet.com.
You can find my sourcecode at voxpupuli/vox-pupuli-tasks

Will do, thanks.

@oleksandriegorov
Copy link
Contributor Author

All checks passed. Also added positive and negative checks for "Interval" setting.

@ghoneycutt
Copy link
Member

Great work!

@ghoneycutt ghoneycutt merged commit 3daaf69 into voxpupuli:master May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants