Convert mocha tests to rspec #952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dear @KeithWard, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs? |
KeithWard
force-pushed
the
convert_mocha_to_rspec
branch
3 times, most recently
from
b6a7148
to
cdb590b
Compare
KeithWard
force-pushed
the
convert_mocha_to_rspec
branch
from
cdb590b
to
db28e07
Compare
Looks like the whiteslace plugin introduced in 2.0 has a few issues. Temporarily pinning voxpupuli-test at 1.5 to see if this clears the issues in CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This PR converts the rspec tests used for testing the fact to rspec, rather than mocha, to match the other voxpupuli modules.