Drop erroneous double quotes from virt plugin template #954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for the PR! can you add a test to ensure it works now? |
|
Heh I knew that was coming :) |
leifmadsen
force-pushed
the
lmadsen-drop-quotes-hostname-format
branch
from
65b52ae
to
3a4250e
Compare
leifmadsen
force-pushed
the
lmadsen-drop-quotes-hostname-format
branch
from
3a4250e
to
34bc600
Compare
Use of double-quotes around the HostnameFormat field in the virt plugin erb template is wrong when using multiple names. Error generated will be [2020-09-04 03:17:04] virt plugin: unknown HostnameFormat field: name metadata uuid when setting the configuration to HostnameFormat "name metadata uuid" Simply removing the double quotes allows for a successful virt plugin load. Source in collectd justifying this change is at: https://github.com/collectd/collectd/blob/main/src/virt.c#L834 Fixes voxpupuli#953
leifmadsen
force-pushed
the
lmadsen-drop-quotes-hostname-format
branch
from
34bc600
to
5ab718b
Compare
|
@bastelfreak all done! :) |
|
Any chance I can get a review and have this merged? |
kenyon
approved these changes
Dec 9, 2020
ghoneycutt
approved these changes
Jan 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use of double-quotes around the HostnameFormat field in the virt plugin erb
template is wrong when using multiple names. Error generated will be
[2020-09-04 03:17:04] virt plugin: unknown HostnameFormat field: name metadata uuid
when setting the configuration to
HostnameFormat "name metadata uuid"
Simply removing the double quotes allows for a successful virt plugin load. Source
in collectd justifying this change is at: https://github.com/collectd/collectd/blob/main/src/virt.c#L834
Fixes #953