Add PluginInstanceFormat parameter to virt plugin #955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leifmadsen
force-pushed
the
lmadsen-add-virt-plugininstanceformat
branch
from
26e3103
to
e56e713
Compare
leifmadsen
force-pushed
the
lmadsen-add-virt-plugininstanceformat
branch
from
e56e713
to
0a255d1
Compare
|
@igalic test added |
bastelfreak
reviewed
Sep 18, 2020
…ceFormat parameter to the virt plugin to allow forspecifying the plugin instance format, resulting in a new label beingavailable to the virt metrics. By adding this you can provide the UUIDof the virtual machine, along with HostnameFormat to have informationabout VMs that exist per physical host.Adds spec test to validate that PluginInstanceFormat is available incollectd version 5.5.0 or later.
leifmadsen
force-pushed
the
lmadsen-add-virt-plugininstanceformat
branch
from
0a255d1
to
20494e4
Compare
bastelfreak
approved these changes
Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the PluginInstanceFormat parameter to the virt plugin to allow for specifying the
plugin instance format, resulting in a new label being available to the virt metrics. By
adding this you can provide the UUID of the virtual machine, along with HostnameFormat
to have information about VMs that exist per physical host.