Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure plugins installed before service is started #1106

Merged
merged 3 commits into from Jan 5, 2021
Merged

make sure plugins installed before service is started #1106

merged 3 commits into from Jan 5, 2021

Conversation

shamil
Copy link
Contributor

@shamil shamil commented Dec 29, 2020

Pull request acceptance prerequisites:

  • Signed the CLA (if not already signed)
  • Rebased/up-to-date with base branch
  • Tests pass
  • Updated CHANGELOG.md with patch notes (if necessary)
  • Updated CONTRIBUTORS (if attribution is requested)

@elasticmachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@shamil
Copy link
Contributor Author

shamil commented Dec 30, 2020

@fatmcgav can you please take a look at this change. Currently this blocking from us to upgrade the module, since we install some plugins.

@fatmcgav
Copy link
Contributor

@shamil thanks for putting in a fix.
I'm currently on vacation, back on the 4th, so can look at doing a formal review and merge then...

The changes all look sane though.
One minor one - would you be able to add some tests that verify this behaviour?

Thanks

@shamil
Copy link
Contributor Author

shamil commented Dec 30, 2020

@fatmcgav added test

Copy link
Contributor

@fatmcgav fatmcgav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tweak to the test, but otherwise this LGTM :)

spec/defines/004_elasticsearch_plugin_spec.rb Show resolved Hide resolved
Copy link
Contributor

@fatmcgav fatmcgav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shamil
Copy link
Contributor Author

shamil commented Jan 4, 2021

Thanks for approval @fatmcgav
Do I need to do anything else to get this PR merged and get bug-fix release ;) ?

@fatmcgav fatmcgav merged commit 62cf708 into voxpupuli:master Jan 5, 2021
@fatmcgav
Copy link
Contributor

fatmcgav commented Jan 5, 2021

@shamil I've just merged this PR. Thanks again for the contribution.

WRT a bug-fix release, I'll look to get that done this week, as there's a couple of other PR's I want to follow up on aswell :)

@shamil shamil deleted the patch-1 branch January 5, 2021 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants