Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in variable name #24

Closed
pawilon opened this issue Jan 30, 2017 · 3 comments
Closed

Typo in variable name #24

pawilon opened this issue Jan 30, 2017 · 3 comments

Comments

@pawilon
Copy link

pawilon commented Jan 30, 2017

Thank you for a very useful module. Unfortunately, my tests with strict variable checking are failing because there's a typo in puppet-fail2ban/manifests/jail.pp:12:

$maxretry                    = $fail2ban::maxtretry,

righthand side has an extra t, should be $fail2ban::maxretry
@dhoppe
Copy link
Member

dhoppe commented Feb 2, 2017

Hello @pawilon,

could you please provide a pull request against the develop branch?

Thank you very much.

rigved pushed a commit to EnduranceIndia/puppet-fail2ban that referenced this issue Feb 9, 2017
- Corrected typo in variable name: maxretry
1cbb476 
- Fixes voxpupuli#24
@rigved rigved mentioned this issue Feb 9, 2017
Merged
dhoppe pushed a commit that referenced this issue Feb 28, 2017
@rigved @dhoppe
Corrected typo in variable name: maxretry (#25)
389f2bb 
* - Corrected typo in variable name: maxretry
- Fixes #24

* Fix travis-CI error: 'Style/MethodCallParentheses' cop has been renamed to 'Style/MethodCallWithoutArgsParentheses'
@davealden
Copy link
Contributor

@dhoppe Any idea as to when you'll release this? I'm dying to switch to this module. :)

@fcanovai
Copy link
Contributor

fcanovai commented Aug 1, 2018

This typo is still present in the master version

ekohl added a commit to ekohl/puppet-fail2ban that referenced this issue Aug 1, 2018
@ekohl
Fix typo in parameter default
952d1ae 
Fixes voxpupuli#24
@ekohl ekohl mentioned this issue Aug 1, 2018
Merged
cegeka-jenkins pushed a commit to cegeka/puppet-fail2ban that referenced this issue Mar 30, 2020
@ekohl
Fix typo in parameter default
3b395fc 
Fixes voxpupuli#24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dhoppe @davealden @fcanovai @pawilon