Fix non namespaced extlib function #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the `default_content`, from extlib module, function usage: this non-namespeced function is deprecated since extlib v3 and have been removed in v5.
smortex
approved these changes
Apr 3, 2020
|
Hi @neomilium, thanks for the fix! Can you please update the minimal version of extlib in https://github.com/voxpupuli/puppet-fail2ban/blob/master/metadata.json#L13 to the one that has the namespaced version? |
|
Minimum version is already correct. |
|
@neomilium Thanks! |
|
I've taken a look at what might be blocking a new release. Could you help with #116 (comment) ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the
default_content, from extlib module, function usage: this non-namespaced function is deprecated since extlib v3 and have been removed in v5.Please note that releasing a new version could be welcome by users ;-)
BTW, thanks for your work.