Support overriding service notifications (#143) #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Apr 28, 2020
templates/common/sendmail.conf.epp
Outdated
| [Init] | ||
| <% $config.keys.each |$key| { -%> | ||
| <%= $key %> = <%= $fail2ban::sendmail_config[$key] %> | ||
| <% } -%> |
There was a problem hiding this comment.
please fix the missing \n at the end of the file
bastelfreak
reviewed
Apr 28, 2020
templates/common/sendmail.conf.epp
Outdated
| @@ -0,0 +1,11 @@ | |||
| # Override the Fail2Ban defaults in sendmail-common.conf with these entries | |||
| <% include stdlib %> | |||
There was a problem hiding this comment.
is that include required for anything? I think we can omit it.
bastelfreak
added
enhancement
|
Hi @deric, thanks for the work! I made a tiny inline comment. Please have a look. |
|
@bastelfreak Sure thing, all objections should be fixed. |
|
Unfortunately these changes aren't enough to disable notifications. Notifications are defined in multiple files. $ fail2ban-client get sshd action sendmail-buffered actionstart
printf %b "Subject: [Fail2Ban] <name>: started on `uname -n`
From: <sendername> <<sender>>
To: <dest>\n
Hi,\n
The jail <name> has been started successfully.\n
Output will be buffered until <lines> lines are available.\n
Regards,\n
Fail2Ban" | /usr/sbin/sendmail -f <sender> <dest>I'll try to include integration tests in order to ensure that this really works as expected. |
|
thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Support e-mail notification configuration directly from Puppet/Hiera.
This Pull Request (PR) fixes the following issues
Fixes #143