Add support for Ubuntu 22.04

[grant-veepshosting]

Pull Request (PR) description

Add support for Ubuntu 22.04, compatible with 22.04 template.

This Pull Request (PR) fixes the following issues

Ubuntu LTS compatibility.

[tarjei]

@smortex is the thing this is waiting for Puppet to have builds for 22.04?

[smortex]

@tarjei thanks for the heads up… Looks like I messed with my tabs when reviewing a bunch of PR including this one (was probably linking this to another PR that just updated metadata.json to add Ubuntu 22.04 support).

[smortex]

That's probably fine and can supposedly be merged as is. The next Puppet release should have Ubuntu 22.04 support, so maybe we can also wait for that release and add it to metadata.json so that the test suite run against it?

[brunoleon]

Can you merge this now the 22.04 support is there ?

[smortex]

Thanks for the heads up @brunoleon!

I added a commit so that support for this version of Ubuntu is visible and to allow the test suite to test against this version. Unfortunately, some work is needed to fix CI (because the branch is old, it is merged with the current master before the test suite start).

@grant-veepshosting Can you please rebase your branch on top of the main one?

From your branch in your fork:

git pull               # Get the commit I added on top of your fork
git remote add vox https://github.com/voxpupuli/puppet-fail2ban.git # Add a "vox" remote for this repo
git fetch vox          # Download the latest code we have here
git rebase vox/master  # Move your commits on top of the main branch
git push -f            # Send the changes (-f is required because we re-wrote history)

Then the line number is the CI report will make sense and fixing the issue will be possible.

Thanks!

[grant-veepshosting]

Done now, thanks for providing the steps and your patience - busy start to the week.

[smortex]

Nice, thanks! The remaining CI failure should be easy to fix 😉, do you mind give it a try?

Failures:

  1) fail2ban on ubuntu-22.04-x86_64 is expected to contain Class[fail2ban] with config_file_template => "a new os.name or os.release.major needs a new case"
     Failure/Error: it { is_expected.to contain_class('fail2ban').with_config_file_template('a new os.name or os.release.major needs a new case') }
       expected that the catalogue would contain Class[fail2ban] with config_file_template set to "a new os.name or os.release.major needs a new case" but it is set to "fail2ban/Ubuntu/22.04/etc/fail2ban/jail.conf.epp"
     # ./spec/classes/init_spec.rb:43:in `block (4 levels) in <top (required)>'

Finished in 18.17 seconds (files took 11.33 seconds to load)
525 examples, 1 failure

puppet-fail2ban/spec/classes/init_spec.rb

Lines 37 to 44 in 9cd8afc

	when ['Ubuntu', '18.04']
	it { is_expected.to contain_class('fail2ban').with_config_file_template('fail2ban/Ubuntu/18.04/etc/fail2ban/jail.conf.epp') }
	when ['Ubuntu', '20.04']
	it { is_expected.to contain_class('fail2ban').with_config_file_template('fail2ban/Ubuntu/20.04/etc/fail2ban/jail.conf.epp') }
	else
	# has to be better way of doing this.
	it { is_expected.to contain_class('fail2ban').with_config_file_template('a new os.name or os.release.major needs a new case') }
	end

[smortex]

LGTM