Addes the option of banaction #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stonewalljones
force-pushed
the
feature/manage-banacation
branch
from
f458fa5
to
2a60067
Compare
stonewalljones
force-pushed
the
feature/manage-banacation
branch
from
2a60067
to
4cc6e4a
Compare
bastelfreak
reviewed
Mar 30, 2018
| @@ -30,6 +30,7 @@ | |||
| $service_enable = true, | |||
|
|
|||
| $action = 'action_mb', | |||
| $banaction = 'iptables-multiport', | |||
There was a problem hiding this comment.
please add a datatype for the new parameter
|
Hi @stonewalljones, thanks for the PR. This module got recently migrated to Vox Pupuli. We require a datatype for new parameters. Can you please add it and rebase? |
|
I'm interested on this PR. I can pick it up from here if the OP is does not have time to work on it anymore. |
|
thanks for your interest @danifr ! You can checkout the branch, push it to your fork and resubmit it as a new pull request. |
|
Hi Tim, I'm afraid this feature was added already here e14b293. I think we can close this one :) |
|
ah alright, thanks for the info. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allow the ability to set the ban action for RHEL/CentOS 7 (Manipo) systems