support a backend parameter for jails #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Mar 30, 2018
manifests/jail.pp
Outdated
| @@ -37,6 +38,7 @@ | |||
| if $findtime { validate_integer($findtime) } | |||
| if $bantime { validate_integer($bantime) } | |||
| if $port { validate_string($port) } | |||
| if $backend { validate_string($action) } | |||
There was a problem hiding this comment.
Please add a datatype instead of a validate_* call
|
Hi @qs5779, thanks for the PR. Can you please take a look at the inline comment I made? Also please take a look at the used email address. It isn't associated with your github account. |
|
I made the change you requested. I also changed my email setting to NOT private so hopefully the email issue is resolved. |
|
done, thanks for the review
Sent: Thursday, March 29, 2018 at 9:58 PM
From: "Tim Meusel" <notifications@github.com>
To: voxpupuli/puppet-fail2ban <puppet-fail2ban@noreply.github.com>
Cc: "Quien Sabe" <qs5779@mail.com>, Author <author@noreply.github.com>
Subject: Re: [voxpupuli/puppet-fail2ban] support a backend parameter for jails (#37)
@bastelfreak commented on this pull request.
In manifests/jail.pp:
@@ -37,6 +38,7 @@
if $findtime { validate_integer($findtime) }
if $bantime { validate_integer($bantime) }
if $port { validate_string($port) }
+ if $backend { validate_string($action) }
Please add a datatype instead of a validate_* call
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Can you please rebase to get rid of the merge commit and check the used email address in the commits? |
|
I am pretty sure I fouled everything up by pushing my local branch after a botched rebase attempt.
I sorry to cause you issues. Please feel free to accept the request or simply close it. I am no longer using the module as I have moved most of my servers to version 10 of fail2ban for the ipv6 support.
I did correcte my local .gitconfig so future commits will match up with a github email adddress.
Thanks.
Jim
Sent: Friday, March 30, 2018 at 7:22 PM
From: "Tim Meusel" <notifications@github.com>
To: voxpupuli/puppet-fail2ban <puppet-fail2ban@noreply.github.com>
Cc: "Quien Sabe" <qs5779@mail.com>, Mention <mention@noreply.github.com>
Subject: Re: [voxpupuli/puppet-fail2ban] support a backend parameter for jails (#37)
Can you please rebase to get rid of the merge commit and check the used email address in the commits?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
bastelfreak
added
enhancement
|
Thanks for the work @qs5779! I rebased the branch and will merge it when travis turns green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On RedHat systems there is a nagging systemd backend issue that is causing many headaches. The only brute force way at the moment to avoid getting an automatic systemd backend is to set the default_backend, and backend in each jail, to a value other than systemd or auto.
This pull request adds a parameter, to jail.pp to support an optional backend parameter.