sender email variabilized #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
approved these changes
May 2, 2018
manifests/init.pp
Outdated
| @@ -32,6 +32,7 @@ | |||
| $action = 'action_mb', | |||
| $bantime = 432000, | |||
| $email = "fail2ban@${::domain}", | |||
| $sender = 'fail2ban@localhost', | |||
There was a problem hiding this comment.
I realize this was @localhost before, but should this be fail2ban@${::fqdn} by default?
There was a problem hiding this comment.
I am not sure to know but what you say seems more logical to me.
Do you want me to update the PR?
ekohl
approved these changes
May 4, 2018
|
Thanks! |
saibot94
pushed a commit
to saibot94/puppet-fail2ban
that referenced
this pull request
May 7, 2018
cegeka-jenkins
pushed a commit
to cegeka/puppet-fail2ban
that referenced
this pull request
Mar 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
The
senderemail was not variablized as for thedestemail.This Pull Request (PR) fixes the following issues
Fixes #51