Use Puppet 4 datatypes #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
requested changes
May 4, 2018
manifests/define.pp
Outdated
| $config_file_string = undef, | ||
| $config_file_template = undef, | ||
| Stdlib::Absolutepath $config_file_path = "${fail2ban::config_dir_path}/${title}", | ||
| String $config_file_owner = $fail2ban::config_file_owner, |
There was a problem hiding this comment.
can you align everything at = please?
There was a problem hiding this comment.
I chose not to align at all and use single spaces.
manifests/define.pp
Outdated
| $config_file_source = undef, | ||
| $config_file_string = undef, | ||
| $config_file_template = undef, | ||
| Stdlib::Absolutepath $config_file_path = "${fail2ban::config_dir_path}/${title}", |
bastelfreak
approved these changes
May 4, 2018
|
as discussed on IRC: We will open a PR on our review guidelines to discuss parameter alignment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #44