Add ignoreip parameter to jail class and template #60
Conversation
|
Hi @leonkoens, thanks for the PR. Can you please document the new parameter in the README.md? |
manifests/jail.pp
Outdated
| @@ -14,6 +14,7 @@ | |||
| Integer $bantime = $fail2ban::bantime, | |||
| Optional[String] $port = undef, | |||
| Optional[String] $backend = undef, | |||
| Optional[Array] $ignoreip = undef, | |||
There was a problem hiding this comment.
Please take a look at our review guidelines:
Are there new params with datatype Hash or Array? If possible, they should default to empty Hash/Array instead of undef. You can also enforce the datastructure like Array[String]
Can you please migration the Datatype to something like Array[String[1]]? What kind of ip addresses are valid? Stdlib has quite some datatypes. One of them is probably useful in this case so it could even be Array[Stdlib::IP::Address]
There was a problem hiding this comment.
We probably need to update the lowest supported stdlib version in the metadata.json as well, since the new types got introduces in stdlib 4.25.0.
manifests/jail.pp
Outdated
| @@ -14,6 +14,7 @@ | |||
| Integer $bantime = $fail2ban::bantime, | |||
| Optional[String] $port = undef, | |||
| Optional[String] $backend = undef, | |||
| Optional[Array[Stdlib::IP::Address]] $ignoreip = [], | |||
There was a problem hiding this comment.
you can remove the Optional[]
There was a problem hiding this comment.
Heh, I was wondering if this was still necessary. Removing it.
bastelfreak
added
enhancement
…arameter Add ignoreip parameter to jail class and template
Pull Request (PR) description
This pull request adds support for defining ignoreip's in the fail2ban jails.