Add unit test for checking sender address

[smortex]

Pull Request (PR) description

The Debian Stretch template use a hardcoded sender address: fail2ban@localhost.

This PR use the sender address configured with $fail2ban::sender instead.

The Debian Stetch template used to have a static sender address, ignoring $fail2ban::sender. This problem was addressed as a side effect of #77 but a unit-test for the correct behavior still makes sense.

This Pull Request (PR) fixes the following issues

n/a

[smortex]

Transient Travis-CI failure 🙄 Trying to be much more lucky by closing/reopening PR…

[bastelfreak]

can you please use @fail2ban::sender to access the variable?

[smortex]

I think you meant $fail2ban::sender, but this is an erb template, not an epp one 😃

[bastelfreak]

The desired way to access a variable in an erb template is @class::variable:
https://puppet.com/docs/puppet/5.5/lang_template_erb.html#variable

[smortex]

Just tested to be absolutely certain that it is not working as expected in erb.

@fail2ban is nil, and nil::sender is basically nil.sender, so:

fail2ban
  on debian-9-x86_64
    fail2ban::config
      when content template
        should contain File[fail2ban.conf] with ensure => "present", content =~ /THIS FILE IS MANAGED BY PUPPET/, notify => "Service[fail2ban]", require => "Package[fail2ban]" and content =~ /^chain = INPUT$/ (FAILED - 1)
      when content template (custom)
        should contain File[fail2ban.conf] with ensure => "present", content =~ /THIS FILE IS MANAGED BY PUPPET/, notify => "Service[fail2ban]", require => "Package[fail2ban]" and content =~ /^chain = INPUT$/ (FAILED - 2)
      when iptables chain provided
        should contain File[fail2ban.conf] with content =~ /^chain = TEST$/ (FAILED - 3)
      when custom banaction is provided
        should contain File[fail2ban.conf] with content =~ /^banaction = iptables$/ (FAILED - 4)
[...]
Failures:

  1) fail2ban on debian-9-x86_64 fail2ban::config when content template should contain File[fail2ban.conf] with ensure => "present", content =~ /THIS FILE IS MANAGED BY PUPPET/, notify => "Service[fail2ban]", require => "Package[fail2ban]" and content =~ /^chain = INPUT$/
     Failure/Error: return call_function('template', template_name) unless template_name.end_with?('.epp')
     
     Puppet::PreformattedError:
       Evaluation Error: Error while evaluating a Function Call, Failed to parse template fail2ban/stretch/etc/fail2ban/jail.conf.erb:
         Filepath: /usr/home/romain/Projects/puppet/modules/fail2ban/spec/fixtures/modules/fail2ban/templates/stretch/etc/fail2ban/jail.conf.erb
         Line: 75
         Detail: undefined method `sender' for nil:NilClass

[bastelfreak]

That maybe doesn't work because sender isn't a variable within the fail2ban::jail class. let's stick with the scope way.

[bastelfreak]

Hi @smortex, thanks for the fix. Can you please add a test that sets the variable and verifies the file content?

[bastelfreak]

#76 this just got merged and should fix your travis issues. Can you please rebase against our latest master?

[smortex]

@bastelfreak I added a commit that adds an acceptance test to show the problem on top of master, then moved the commit you previously saw on top if this to fix the issue.

[bastelfreak]

@smortex can you please rebase? Afterwards I can merge this.

[smortex]

@bastelfreak I am working on it ;-) #77 has superseded these changes, but the unit test for checking the sender may still make sense.

[smortex]

@bastelfreak I just rebased the branch on top of master with all that was added today \o/.

Thank you for the hard work :-)

[bastelfreak]

Thanks!