Switch to epp templates #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generated fail2ban.conf used to contain the full path to the template used for generating the file on the Puppet Master. This was made uneffective by the switch to epp templates. Because it used to display the full path of the template on the Pullet Master, it produces more clutter than value when switching environment for testing changes (each environment changes the content of fail2ban.conf). For this reason, drop this feature.
|
Thanks @smortex ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Now that voxpupuli/puppet-extlib#103 is merged, we can switch from erb to epp templates, allowing to use the Puppet syntax in templates, and making them easier to read.
This Pull Request (PR) fixes the following issues
n/a