Review gitlab.rb Template

[tobru]

Gitlab has progressed a lot in the last months. The file templates/gitlab.rb.erb needs to be revised and aligned to the template found in Omnibus.

[james-powis]

doing some grep foo and looking at the diff from HEAD > omnibus 8.0 the following 2 groupings are not supported currently by this module:

+# sentinel['bind'] = '0.0.0.0'
+# sentinel['port'] = 26379
+# sentinel['quorum'] = 1
+# sentinel['down_after_milliseconds'] = 10000
+# sentinel['failover_timeout'] = 60000
+# sidekiq_cluster['enable'] = false
+# sidekiq_cluster['ha'] = false
+# sidekiq_cluster['log_directory'] = "/var/log/gitlab/sidekiq-cluster"
+# sidekiq_cluster['interval'] = 5 # The number of seconds to wait between worker checks
+# sidekiq_cluster['queue_groups'] = [

[james-powis]

best I can tell every other config directive is covered by the existing template.

[tobru]

Thanks! It's not just adding parameters, but also removing deprecated parameters... Will hopefully work on this over the next weeks.

[matonb]

Would these parameters fit in this category ?

gitlab_rails['backup_path'] = <path>
git_data_dirs({"default" => "<path>"})

[tobru]

Would these parameters fit in this category ?

Yes =) See also #110

[davidgubler]

All the configuration options mentioned above should be supported now. I recently added the missing git_data_dirs (thanks to Corey Osman) and sidekiq_cluster options (19ff7e0).

[LongLiveCHIEF]

So it turns out that git_data_dirs is currently misdocumented. The correct hash for this should look like:

#correct
git_data_dirs({'default' => {'path' => '/git/data/path'}})

#incorrect
git_data_dirs({'default' => '/git/data/path'})

see: https://gitlab.com/gitlab-org/gitlab-ee/issues/4040#note_54368948