Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extra_hosts settings in config.toml ? #121

Closed
KlavsKlavsen opened this issue Mar 3, 2017 · 4 comments
Closed

extra_hosts settings in config.toml ? #121

KlavsKlavsen opened this issue Mar 3, 2017 · 4 comments
Labels
enhancement New feature or request

Comments

@KlavsKlavsen
Copy link

for some reason I've hit a docker issue with DNS lookups.. so I need to add:

extra_hosts = ["mygiturl:mygithostip"] - to config.toml - under runners.docker.

The module does not support this currently.. and does not handle if config.toml file is missing :(

Any plans for supporting setting such settings on runner setup ?

@tobru
Copy link
Contributor

tobru commented Mar 15, 2017

Yes, why not. Are you willing to create a PR?

@KlavsKlavsen
Copy link
Author

currently you're using fileline to change that file.. whats the reason for not controlling the entire file?

@KlavsKlavsen
Copy link
Author

and yes - I'll gladly do a PR.. if we agree on how best to solve it :)

@juniorsysadmin juniorsysadmin added the enhancement New feature or request label Jan 29, 2018
@LongLiveCHIEF
Copy link
Contributor

Functionality for gitlab runner is being moved into its own module at https://github.com/voxpupuli/puppet-gitlab_ci_runner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants